Coding standards

Coding standards

Hi!

Checked few source files from SDK and like to say - please improove it's readability. 

Just an example 

if (sts<PXC_STATUS_NO_ERROR) return false;
if (m_gesture_pinfo.sets) m_gesture->SubscribeGesture(100,this);
if (m_gesture_pinfo.alerts) m_gesture->SubscribeAlert(this);

How many time you need to read just 3 lines of code and to understand what it do?

3 posts / 0 new
Last post
For more complete information about compiler optimizations, see our Optimization Notice.

Hi Dmitry, thank you for your feedback!
We will improve readability of samples code and it will be fixed in future releases. Thanks! Konstantin

Can you explain in more details?
(1) If the status is an error, return false. The manual says all errors are negative numbers, and all warnings are positive numbers.
(2) If the configuration needs to receive any gesture events, subscribe to receive the events.
(3) If the configuration needs to receive any alert events, subscribe to receive the events.

Leave a Comment

Please sign in to add a comment. Not a member? Join today